Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93274e4d authored by Stefani Seibold's avatar Stefani Seibold Committed by Linus Torvalds
Browse files

fbcon: fix rotate upside down crash 



Fix the rotate_ud() function not to crash in case of a font which has not
a width of multiple by 8: The inner loop of the font pixel copy should not
access a bit outside the font memory area.  Subtract the shift offset from
the font width will prevent this.

Signed-off-by: default avatarStefani Seibold <stefani@seibold.net>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69dd647f

drivers/video/console/fbcon_rotate.h

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ static inline void rotate_ud(const char *in, char *out, u32 width, u32 height) 
	width = (width + 7) & ~7;



	for (i = 0; i < height; i++) {

		for (j = 0; j < width; j++) {

		for (j = 0; j < width - shift; j++) {

			if (pattern_test_bit(j, i, width, in))

				pattern_set_bit(width - (1 + j + shift),

						height - (1 + i),