Commit 8f50c7f5 authored Jul 27, 2011 by Dan Carpenter Committed by Nicholas Bellinger Jul 27, 2011

iscsi-target: strlen() doesn't count the terminator



This patch fixes an off by one check in iscsit_add_tiqn() because the
NULL terminator isn't taken into consideration.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 4a28a3fa

drivers/target/iscsi/iscsi_target.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ struct iscsi_tiqn iscsit_add_tiqn(unsigned char buf)
		struct iscsi_tiqn *tiqn = NULL;
		int ret;

		if (strlen(buf) > ISCSI_IQN_LEN) {
		if (strlen(buf) >= ISCSI_IQN_LEN) {
		pr_err("Target IQN exceeds %d bytes\n",
		ISCSI_IQN_LEN);
		return ERR_PTR(-EINVAL);