Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86c838b0 authored by Julia Lawall's avatar Julia Lawall Committed by Mark Fasheh
Browse files

[PATCH] fs/ocfs2/aops.c: Correct use of ! and & 



In commit e6bafba5, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarMark Fasheh <mark.fasheh@oracle.com>
parent 05488bbe

fs/ocfs2/aops.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -257,7 +257,7 @@ static int ocfs2_readpage_inline(struct inode *inode, struct page *page) 
	struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);

	struct ocfs2_super *osb = OCFS2_SB(inode->i_sb);





	BUG_ON(!PageLocked(page));

	BUG_ON(!PageLocked(page));

	BUG_ON(!OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL);

	BUG_ON(!(OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL));





	ret = ocfs2_read_block(osb, OCFS2_I(inode)->ip_blkno, &di_bh,

	ret = ocfs2_read_block(osb, OCFS2_I(inode)->ip_blkno, &di_bh,

			       OCFS2_BH_CACHED, inode);

			       OCFS2_BH_CACHED, inode);