Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8188df17 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4.1: Use the more efficient open_noattr call for open-by-filehandle 



When we're doing open-by-filehandle in NFSv4.1, we shouldn't need to
do the cache consistency revalidation on the directory. It is
therefore more efficient to just use open_noattr, which returns the
file attributes, but not the directory attributes.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent fd068b20

fs/nfs/nfs4proc.c

+6 −2
Original line number Diff line number Diff line
@@ -1549,9 +1549,13 @@ static void nfs4_open_prepare(struct rpc_task *task, void *calldata) 
	}

	/* Update client id. */

	data->o_arg.clientid = clp->cl_clientid;

	if (data->o_arg.claim == NFS4_OPEN_CLAIM_PREVIOUS) {

		task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_OPEN_NOATTR];

	switch (data->o_arg.claim) {

	case NFS4_OPEN_CLAIM_PREVIOUS:

	case NFS4_OPEN_CLAIM_DELEG_CUR_FH:

	case NFS4_OPEN_CLAIM_DELEG_PREV_FH:

		data->o_arg.open_bitmap = &nfs4_open_noattr_bitmap[0];

	case NFS4_OPEN_CLAIM_FH:

		task->tk_msg.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_OPEN_NOATTR];

		nfs_copy_fh(&data->o_res.fh, data->o_arg.fh);

	}

	data->timestamp = jiffies;