Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7f3bedcc authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by Ingo Molnar
Browse files

perf record: Fix race where process can disappear while reading its /proc/pid/tasks 



Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256592199-9608-1-git-send-email-acme@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent fcd14b32

tools/perf/builtin-record.c

+4 −0
Original line number Diff line number Diff line
@@ -206,6 +206,7 @@ static pid_t pid_synthesize_comm_event(pid_t pid, int full) 


	fp = fopen(filename, "r");

	if (fp == NULL) {

out_race:	

		/*

		 * We raced with a task exiting - just return:

		 */
@@ -247,6 +248,9 @@ static pid_t pid_synthesize_comm_event(pid_t pid, int full) 
	snprintf(filename, sizeof(filename), "/proc/%d/task", pid);



	tasks = opendir(filename);

	if (tasks == NULL)

		goto out_race;



	while (!readdir_r(tasks, &dirent, &next) && next) {

		char *end;

		pid = strtol(dirent.d_name, &end, 10);