Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79442d38 authored by Jesse Brandeburg's avatar Jesse Brandeburg Committed by Jeff Kirsher
Browse files

i40e: clean up throttle rate code 



The interrupt throttle rate minimum is actually 2us, so
fix that define and while we are there, remove some unused defines.

Change some strings in the function to be a bit less wrappy, and
express the correct limits.

Change-ID: I96829bbc77935e0b57c6f0fc1439fb4152b2960a
Signed-off-by: default avatarJesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: default avatarPatrick Lu <patrick.lu@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 21536717

drivers/net/ethernet/intel/i40e/i40e_ethtool.c

+4 −7
Original line number Diff line number Diff line
@@ -1575,11 +1575,9 @@ static int i40e_set_coalesce(struct net_device *netdev, 
	} else if (ec->rx_coalesce_usecs == 0) {

		vsi->rx_itr_setting = ec->rx_coalesce_usecs;

		if (ec->use_adaptive_rx_coalesce)

			netif_info(pf, drv, netdev,

				   "Rx-secs=0, need to disable adaptive-Rx for a complete disable\n");

			netif_info(pf, drv, netdev, "rx-usecs=0, need to disable adaptive-rx for a complete disable\n");

	} else {

		netif_info(pf, drv, netdev,

			   "Invalid value, Rx-usecs range is 0, 8-8160\n");

		netif_info(pf, drv, netdev, "Invalid value, rx-usecs range is 0-8160\n");

		return -EINVAL;

	}
@@ -1589,11 +1587,10 @@ static int i40e_set_coalesce(struct net_device *netdev, 
	} else if (ec->tx_coalesce_usecs == 0) {

		vsi->tx_itr_setting = ec->tx_coalesce_usecs;

		if (ec->use_adaptive_tx_coalesce)

			netif_info(pf, drv, netdev,

				   "Tx-secs=0, need to disable adaptive-Tx for a complete disable\n");

			netif_info(pf, drv, netdev, "tx-usecs=0, need to disable adaptive-tx for a complete disable\n");

	} else {

		netif_info(pf, drv, netdev,

			   "Invalid value, Tx-usecs range is 0, 8-8160\n");

			   "Invalid value, tx-usecs range is 0-8160\n");

		return -EINVAL;

	}

drivers/net/ethernet/intel/i40e/i40e_txrx.h

+1 −4
Original line number Diff line number Diff line
@@ -30,10 +30,7 @@ 
/* Interrupt Throttling and Rate Limiting Goodies */



#define I40E_MAX_ITR               0x0FF0  /* reg uses 2 usec resolution */

#define I40E_MIN_ITR               0x0004  /* reg uses 2 usec resolution */

#define I40E_MAX_IRATE             0x03F

#define I40E_MIN_IRATE             0x001

#define I40E_IRATE_USEC_RESOLUTION 4

#define I40E_MIN_ITR               0x0001  /* reg uses 2 usec resolution */

#define I40E_ITR_100K              0x0005

#define I40E_ITR_20K               0x0019

#define I40E_ITR_8K                0x003E

drivers/net/ethernet/intel/i40evf/i40e_txrx.h

+1 −4
Original line number Diff line number Diff line
@@ -30,10 +30,7 @@ 
/* Interrupt Throttling and Rate Limiting Goodies */



#define I40E_MAX_ITR               0x0FF0  /* reg uses 2 usec resolution */

#define I40E_MIN_ITR               0x0004  /* reg uses 2 usec resolution */

#define I40E_MAX_IRATE             0x03F

#define I40E_MIN_IRATE             0x001

#define I40E_IRATE_USEC_RESOLUTION 4

#define I40E_MIN_ITR               0x0001  /* reg uses 2 usec resolution */

#define I40E_ITR_100K              0x0005

#define I40E_ITR_20K               0x0019

#define I40E_ITR_8K                0x003E