Commit 74b65417 authored Jul 23, 2011 by Thomas Gleixner Committed by Mike Frysinger Oct 25, 2011

Blackfin: H8606: fixup bogus ioresource init



IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by
IORESOURCE_IRQ_SHAREABLE.

IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting
values, an interrupt can hardly be configured for both level and edge
at the same time. This was introduced in commit 45138439(Blackfin
arch: flash memory map and dm9000 resources updating) of course
without any hint in the changelog what the heck this is supposed to
do.

Acked-by: Javier Herrero <jherrero@hvsistemas.es>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>

parent ae41f32e

arch/blackfin/mach-bf533/boards/H8606.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -54,7 +54,8 @@ static struct resource dm9000_resources[] = {
	[2] = {		[2] = {
	.start = IRQ_PF10,		.start = IRQ_PF10,
	.end = IRQ_PF10,		.end = IRQ_PF10,
	.flags = (IORESOURCE_IRQ \| IORESOURCE_IRQ_HIGHEDGE \| IRQF_SHARED \| IRQF_TRIGGER_HIGH),		.flags = (IORESOURCE_IRQ \| IORESOURCE_IRQ_HIGHEDGE \|
			IORESOURCE_IRQ_SHAREABLE),
	},		},
	};		};