Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 735df29a authored by Wey-Yi Guy's avatar Wey-Yi Guy Committed by John W. Linville
Browse files

iwlwifi: BA scd_flow not match condition detected 



It is a uCode bug which cause the tx queue id not match scd_flow
in compressed block ack frame, and it need to be addressed in uCode.
Currently, driver will log the information when it happen.

Since it is possible happen very often and we do not want to fill the syslog,
so don't enable the logging by default.

Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 5fc97f77

drivers/net/wireless/iwlwifi/iwl-agn-tx.c

+8 −1
Original line number Diff line number Diff line
@@ -1331,7 +1331,14 @@ void iwlagn_rx_reply_compressed_ba(struct iwl_priv *priv, 
	tid = ba_resp->tid;

	agg = &priv->stations[sta_id].tid[tid].agg;

	if (unlikely(agg->txq_id != scd_flow)) {

		IWL_ERR(priv, "BA scd_flow %d does not match txq_id %d\n",

		/*

		 * FIXME: this is a uCode bug which need to be addressed,

		 * log the information and return for now!

		 * since it is possible happen very often and in order

		 * not to fill the syslog, don't enable the logging by default

		 */

		IWL_DEBUG_TX_REPLY(priv,

			"BA scd_flow %d does not match txq_id %d\n",

			scd_flow, agg->txq_id);

		return;

	}