Commit 71ea1483 authored Aug 10, 2013 by Dan Carpenter Committed by Dan Williams Aug 22, 2013

dmaengine: make dma_submit_error() return an error code



The problem here is that the dma_xfer() functions in
drivers/ata/pata_arasan_cf.c and drivers/mtd/nand/fsmc_nand.c expect
dma_submit_error() to return an error code so they return 1 when they
intended to return a negative.

So far as I can tell, none of the ->tx_submit() functions ever do
return error codes so this patch should have no effect in the current
code.

I also changed it from a define to an inline.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dan Williams <djbw@fb.com>

parent c4dcf0e2

include/linux/dmaengine.h

+4 −1

Original line number	Original line	Diff line number	Diff line
	@@ -38,7 +38,10 @@ typedef s32 dma_cookie_t;
	#define DMA_MIN_COOKIE 1		#define DMA_MIN_COOKIE 1
	#define DMA_MAX_COOKIE INT_MAX		#define DMA_MAX_COOKIE INT_MAX

	#define dma_submit_error(cookie) ((cookie) < 0 ? 1 : 0)		static inline int dma_submit_error(dma_cookie_t cookie)
			{
			return cookie < 0 ? cookie : 0;
			}

	/**		/**
	* enum dma_status - DMA transaction status		* enum dma_status - DMA transaction status