Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 712a4338 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Fix xs_setup_bc_tcp() 



It is a BUG for anybody to call this function without setting
args->bc_xprt. Trying to return an error value is just wrong, since the
user cannot fix this: it is a programming error, not a user error.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent ff839970

net/sunrpc/xprtsock.c

+0 −3
Original line number Original line Diff line number Diff line
@@ -2442,9 +2442,6 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) 
	struct sock_xprt *transport;

	struct sock_xprt *transport;

	struct svc_sock *bc_sock;

	struct svc_sock *bc_sock;





	if (!args->bc_xprt)

		ERR_PTR(-EINVAL);



	xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries);

	xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries);

	if (IS_ERR(xprt))

	if (IS_ERR(xprt))

		return xprt;

		return xprt;