Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d101c58 authored by Jean Delvare's avatar Jean Delvare Committed by Guenter Roeck
Browse files

hwmon: (lm90) Make SA56004 detection more robust 



With a device ID register value of 0, the SA56004 detection is rather
weak. Check several other register too to confirm the detection, as we
do for other supported devices.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: Stijn Devriendt <sdevrien@cisco.com>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>
Acked-by: default avatarStijn Devriendt <sdevrien@cisco.com>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent a095f687

drivers/hwmon/lm90.c

+13 −2
Original line number Diff line number Diff line
@@ -1283,8 +1283,19 @@ static int lm90_detect(struct i2c_client *new_client, 
			}

		}

	} else

	if (man_id == 0xA1) { /*  NXP Semiconductor/Philips */

		if (chip_id == 0x00 && address >= 0x48 && address <= 0x4F) {

	if (address >= 0x48 && address <= 0x4F

	 && man_id == 0xA1) { /*  NXP Semiconductor/Philips */

		int reg_config2;



		reg_config2 = i2c_smbus_read_byte_data(new_client,

						LM90_REG_R_CONFIG2);

		if (reg_config2 < 0)

			return -ENODEV;



		if (chip_id == 0x00

		 && (reg_config1 & 0x2A) == 0x00

		 && (reg_config2 & 0xFE) == 0x00

		 && reg_convrate <= 0x09) {

			name = "sa56004";

		}

	}