Commit 6bd0405b authored Jul 05, 2012 by Pablo Neira Ayuso

netfilter: nf_ct_ecache: fix crash with multiple containers, one shutting down



Hans reports that he's still hitting:

BUG: unable to handle kernel NULL pointer dereference at 000000000000027c
IP: [<ffffffff813615db>] netlink_has_listeners+0xb/0x60
PGD 0
Oops: 0000 [#3] PREEMPT SMP
CPU 0

It happens when adding a number of containers with do:

nfct_query(h, NFCT_Q_CREATE, ct);

and most likely one namespace shuts down.

this problem was supposed to be fixed by:
70e9942f netfilter: nf_conntrack: make event callback registration per-netns

Still, it was missing one rcu_access_pointer to check if the callback
is set or not.

Reported-by: Hans Schillstrom <hans@schillstrom.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent a73f89a6

include/net/netfilter/nf_conntrack_ecache.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -78,7 +78,7 @@ nf_conntrack_event_cache(enum ip_conntrack_events event, struct nf_conn *ct)
		struct net *net = nf_ct_net(ct);
		struct nf_conntrack_ecache *e;

		if (net->ct.nf_conntrack_event_cb == NULL)
		if (!rcu_access_pointer(net->ct.nf_conntrack_event_cb))
		return;

		e = nf_ct_ecache_find(ct);