Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69c29fa7 authored by Stefan Richter's avatar Stefan Richter
Browse files

ieee1394: eth1394: remove bogus netif_wake_queue 



When we are within hard_start_xmit, the queue is already awake.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 20e2008e

drivers/ieee1394/eth1394.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -1636,7 +1636,6 @@ static int ether1394_tx(struct sk_buff *skb, struct net_device *dev) 
	if (ether1394_send_packet(ptask, tx_len))

	if (ether1394_send_packet(ptask, tx_len))

		goto fail;

		goto fail;





	netif_wake_queue(dev);

	return NETDEV_TX_OK;

	return NETDEV_TX_OK;

fail:

fail:

	if (ptask)

	if (ptask)
@@ -1650,9 +1649,6 @@ fail: 
	priv->stats.tx_errors++;

	priv->stats.tx_errors++;

	spin_unlock_irqrestore(&priv->lock, flags);

	spin_unlock_irqrestore(&priv->lock, flags);





	if (netif_queue_stopped(dev))

		netif_wake_queue(dev);



	/*

	/*

	 * FIXME: According to a patch from 2003-02-26, "returning non-zero

	 * FIXME: According to a patch from 2003-02-26, "returning non-zero

	 * causes serious problems" here, allegedly.  Before that patch,

	 * causes serious problems" here, allegedly.  Before that patch,