Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65c72efd authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Mark Brown
Browse files

ASoC: mpc5200_dma: Don't overwrite ac97 device private_data 



The mpc5200_dma overwrites the private_data field of the CODEC's AC'97
device with the DMA drivers private data, but never actually reads it again.
Given that the private_data field is supposed to be owned by the AC'97
driver, overwriting it may cause undefined behavior. This patch removes the
code that overwrites the field from the driver.

Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 35480e35

sound/soc/fsl/mpc5200_dma.c

+0 −3
Original line number Diff line number Diff line
@@ -327,9 +327,6 @@ static int psc_dma_new(struct snd_soc_pcm_runtime *rtd) 
			goto capture_alloc_err;

	}



	if (rtd->codec->ac97)

		rtd->codec->ac97->private_data = psc_dma;



	return 0;



 capture_alloc_err: