Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5daf47bb authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

net/rds: Add missing mutex_unlock 

Add a mutex_unlock missing on the error path.  In each case, whenever the
label out is reached from elsewhere in the function, mutex is not locked.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Reviewed-by: default avatarZach Brown <zach.brown@oracle.com>
Acked-by: default avatarAndy Grover <andy.grover@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e72e9f38

net/rds/ib_cm.c

+1 −0
Original line number Diff line number Diff line
@@ -475,6 +475,7 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, 
	err = rds_ib_setup_qp(conn);

	if (err) {

		rds_ib_conn_error(conn, "rds_ib_setup_qp failed (%d)\n", err);

		mutex_unlock(&conn->c_cm_lock);

		goto out;

	}

net/rds/iw_cm.c

+1 −0
Original line number Diff line number Diff line
@@ -452,6 +452,7 @@ int rds_iw_cm_handle_connect(struct rdma_cm_id *cm_id, 
	err = rds_iw_setup_qp(conn);

	if (err) {

		rds_iw_conn_error(conn, "rds_iw_setup_qp failed (%d)\n", err);

		mutex_unlock(&conn->c_cm_lock);

		goto out;

	}