Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c699fb7 authored by Tomasz Gregorek's avatar Tomasz Gregorek Committed by David S. Miller
Browse files

caif: Fix memory leakage in the chnl_net.c. 



Added kfree_skb() calls in the chnk_net.c file on
the error paths.

Signed-off-by: default avatarSjur Brændeland <sjur.brandeland@stericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c9be48dc

net/caif/chnl_net.c

+6 −3
Original line number Diff line number Diff line
@@ -103,6 +103,7 @@ static int chnl_recv_cb(struct cflayer *layr, struct cfpkt *pkt) 
		skb->protocol = htons(ETH_P_IPV6);

		break;

	default:

		kfree_skb(skb);

		priv->netdev->stats.rx_errors++;

		return -EINVAL;

	}
@@ -220,14 +221,16 @@ static int chnl_net_start_xmit(struct sk_buff *skb, struct net_device *dev) 


	if (skb->len > priv->netdev->mtu) {

		pr_warn("Size of skb exceeded MTU\n");

		kfree_skb(skb);

		dev->stats.tx_errors++;

		return -ENOSPC;

		return NETDEV_TX_OK;

	}



	if (!priv->flowenabled) {

		pr_debug("dropping packets flow off\n");

		kfree_skb(skb);

		dev->stats.tx_dropped++;

		return NETDEV_TX_BUSY;

		return NETDEV_TX_OK;

	}



	if (priv->conn_req.protocol == CAIFPROTO_DATAGRAM_LOOP)
@@ -242,7 +245,7 @@ static int chnl_net_start_xmit(struct sk_buff *skb, struct net_device *dev) 
	result = priv->chnl.dn->transmit(priv->chnl.dn, pkt);

	if (result) {

		dev->stats.tx_dropped++;

		return result;

		return NETDEV_TX_OK;

	}



	/* Update statistics. */