Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c2f0513 authored by tom.leiming@gmail.com's avatar tom.leiming@gmail.com Committed by David S. Miller
Browse files

usbnet:pegasus: remove usb_get/put_dev in .probe and .disconnect 



usb_device is parent device of usb_interface in the view of driver
model, so its reference count is always held during .probe/.disconnect
of usb_interface instance.

This patch just removes the unnecessay usb_get/put_dev.

Signed-off-by: default avatarMing Lei <tom.leiming@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ef9d884d

drivers/net/usb/pegasus.c

+0 −4
Original line number Diff line number Diff line
@@ -1329,8 +1329,6 @@ static int pegasus_probe(struct usb_interface *intf, 
	}

	pegasus_count++;



	usb_get_dev(dev);



	net = alloc_etherdev(sizeof(struct pegasus));

	if (!net)

		goto out;
@@ -1407,7 +1405,6 @@ out2: 
out1:

	free_netdev(net);

out:

	usb_put_dev(dev);

	pegasus_dec_workqueue();

	return res;

}
@@ -1425,7 +1422,6 @@ static void pegasus_disconnect(struct usb_interface *intf) 
	pegasus->flags |= PEGASUS_UNPLUG;

	cancel_delayed_work(&pegasus->carrier_check);

	unregister_netdev(pegasus->net);

	usb_put_dev(interface_to_usbdev(intf));

	unlink_all_urbs(pegasus);

	free_all_urbs(pegasus);

	free_skb_pool(pegasus);