Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5635fd0c authored by Dan Carpenter's avatar Dan Carpenter Committed by Eric Van Hensbergen
Browse files

9p: move dereference after NULL check 



We dereferenced "req->tc" and "req->rc" before checking for NULL.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent 464f5ecf

net/9p/client.c

+2 −2
Original line number Diff line number Diff line
@@ -248,10 +248,8 @@ static struct p9_req_t *p9_tag_alloc(struct p9_client *c, u16 tag, int max_size) 
		init_waitqueue_head(req->wq);

		req->tc = kmalloc(sizeof(struct p9_fcall) + alloc_msize,

				  GFP_NOFS);

		req->tc->capacity = alloc_msize;

		req->rc = kmalloc(sizeof(struct p9_fcall) + alloc_msize,

				  GFP_NOFS);

		req->rc->capacity = alloc_msize;

		if ((!req->tc) || (!req->rc)) {

			printk(KERN_ERR "Couldn't grow tag array\n");

			kfree(req->tc);
@@ -261,6 +259,8 @@ static struct p9_req_t *p9_tag_alloc(struct p9_client *c, u16 tag, int max_size) 
			req->wq = NULL;

			return ERR_PTR(-ENOMEM);

		}

		req->tc->capacity = alloc_msize;

		req->rc->capacity = alloc_msize;

		req->tc->sdata = (char *) req->tc + sizeof(struct p9_fcall);

		req->rc->sdata = (char *) req->rc + sizeof(struct p9_fcall);

	}