Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f51b913 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Walleij
Browse files

gpio: Fix return value check in xgene_gpio_probe() 



In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 43a8785a

drivers/gpio/gpio-xgene.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -182,8 +182,8 @@ static int xgene_gpio_probe(struct platform_device *pdev) 
	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	gpio->base = devm_ioremap_nocache(&pdev->dev, res->start,

	gpio->base = devm_ioremap_nocache(&pdev->dev, res->start,

							resource_size(res));

							resource_size(res));

	if (IS_ERR(gpio->base)) {

	if (!gpio->base) {

		err = PTR_ERR(gpio->base);

		err = -ENOMEM;

		goto err;

		goto err;

	}

	}