Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a7795d3 authored by Yan, Zheng's avatar Yan, Zheng Committed by Al Viro
Browse files

vfs: fix reference leak in d_prune_aliases() 



In "d_prune_alias(): just lock the parent and call __dentry_kill()" the old
dget + d_drop + dput has been replaced with lock_parent + __dentry_kill;
unfortunately, dput() does more than just killing dentry - it also drops the
reference to parent.  New variant leaks that reference and needs dput(parent)
after killing the child off.

Signed-off-by: default avatarYan, Zheng <zyan@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ad0eab92

fs/dcache.c

+1 −0
Original line number Diff line number Diff line
@@ -778,6 +778,7 @@ restart: 
			struct dentry *parent = lock_parent(dentry);

			if (likely(!dentry->d_lockref.count)) {

				__dentry_kill(dentry);

				dput(parent);

				goto restart;

			}

			if (parent)