Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40b798ef authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

drivers: Remove BKL from misc_open 



misc_open() is already serialized with misc_mtx. Remove the BKL
locking which got there via the BKL pushdown.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
LKML-Reference: <20091010153349.237173041@linutronix.de>
parent 80f50691

drivers/char/misc.c

+1 −4
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ 
#include <linux/device.h>

#include <linux/tty.h>

#include <linux/kmod.h>

#include <linux/smp_lock.h>



/*

 * Head entry for the doubly linked miscdevice list
@@ -119,7 +118,6 @@ static int misc_open(struct inode * inode, struct file * file) 
	int err = -ENODEV;

	const struct file_operations *old_fops, *new_fops = NULL;



	lock_kernel();

	mutex_lock(&misc_mtx);

	

	list_for_each_entry(c, &misc_list, list) {
@@ -157,7 +155,6 @@ static int misc_open(struct inode * inode, struct file * file) 
	fops_put(old_fops);

fail:

	mutex_unlock(&misc_mtx);

	unlock_kernel();

	return err;

}