Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ac81413 authored by Florin Malita's avatar Florin Malita Committed by Linus Torvalds
Browse files

[PATCH] affs: possible null pointer dereference in affs_rename() 



If affs_bread() fails, the exit path calls mark_buffer_dirty_inode() with a
NULL argument.

Coverity CID: 312.

Signed-off-by: default avatarFlorin Malita <fmalita@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9084533e

fs/affs/namei.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -416,10 +416,9 @@ affs_rename(struct inode *old_dir, struct dentry *old_dentry, 
			return retval;

			return retval;

	}

	}





	retval = -EIO;

	bh = affs_bread(sb, old_dentry->d_inode->i_ino);

	bh = affs_bread(sb, old_dentry->d_inode->i_ino);

	if (!bh)

	if (!bh)

		goto done;

		return -EIO;





	/* Remove header from its parent directory. */

	/* Remove header from its parent directory. */

	affs_lock_dir(old_dir);

	affs_lock_dir(old_dir);