Commit 3828ff45 authored Oct 23, 2007 by Ralph Campbell Committed by Roland Dreier Jan 25, 2008

IB/mad: Remove redundant NULL pointer check in ib_mad_recv_done_handler()



In ib_mad_recv_done_handler(), the response pointer is checked for
NULL after allocating it.  It is then checked again in the local
process_mad() path but there is no possibility of it changing in
between.

Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Acked-by: Hal Rosenstock <hal@xsigo.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent 8d8293cf

drivers/infiniband/core/mad.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -1931,15 +1931,6 @@ local:
		if (port_priv->device->process_mad) {
		int ret;

		if (!response) {
		printk(KERN_ERR PFX "No memory for response MAD\n");
		/*
		* Is it better to assume that
		* it wouldn't be processed ?
		*/
		goto out;
		}

		ret = port_priv->device->process_mad(port_priv->device, 0,
		port_priv->port_num,
		wc, &recv->grh,