Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 344fa462 authored by Lars Ellenberg's avatar Lars Ellenberg Committed by Jens Axboe
Browse files

drbd: improve network latency, TCP_QUICKACK 



On Thu, Apr 29, 2010 at 04:00:50PM -0400, Eduard.Guzovsky@stratus.com
 wrote on drbd-dev@lists.linbit.com
 Subject: [Drbd-dev] DRBD small synchronous writes performance improvements

> 1. TCP_QUICKACK option is set incorrectly. The goal was force TCP to
> send and ACK as a  "one time" event.  Instead the code permanently sets
> connection in the QUICKACK mode.

He is right, we actually want to use an even val with TCP_QUICKACK.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
parent 2c8d1967

drivers/block/drbd/drbd_int.h

+1 −1
Original line number Diff line number Diff line
@@ -1540,7 +1540,7 @@ static inline void drbd_tcp_nodelay(struct socket *sock) 


static inline void drbd_tcp_quickack(struct socket *sock)

{

	int __user val = 1;

	int __user val = 2;

	(void) drbd_setsockopt(sock, SOL_TCP, TCP_QUICKACK,

			(char __user *)&val, sizeof(val));

}