Commit 33b74977 authored Jun 07, 2006 by Benjamin Herrenschmidt Committed by Paul Mackerras Jun 09, 2006

[PATCH] powerpc: Fix call to ibm,client-architecture-support



The code in prom_init.c calling the firmware
ibm,client-architecture-support method on pSeries has a bug where it
fails to properly pass the instance handle of the firmware object when
trying to call a method. Result ranges from the call doing nothing to
the firmware crashing. (Found by Segher, thanks !)

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 7c85d1f9

arch/powerpc/kernel/prom_init.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -822,6 +822,7 @@ static void __init prom_send_capabilities(void)
	/* try calling the ibm,client-architecture-support method */		/* try calling the ibm,client-architecture-support method */
	if (call_prom_ret("call-method", 3, 2, &ret,		if (call_prom_ret("call-method", 3, 2, &ret,
	ADDR("ibm,client-architecture-support"),		ADDR("ibm,client-architecture-support"),
			root,
	ADDR(ibm_architecture_vec)) == 0) {		ADDR(ibm_architecture_vec)) == 0) {
	/* the call exists... */		/* the call exists... */
	if (ret)		if (ret)