Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31304165 authored by Torsten Kaiser's avatar Torsten Kaiser Committed by David S. Miller
Browse files

net: Fix misplaced parenthesis in virtio_net.c 



Commit 2e57b79c misplaced its
parenthesis and now tx_fifo_errors will only be incremented if an
ENOMEM error is not written to the syslog.

Correct the parenthesis and indentation to the original goal of
counting all non ENOMEM errors and ratelimiting only the messages.

Signed-of-by: default avatarTorsten Kaiser <just.for.lkml@googlemail.com>

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 89eb06f1

drivers/net/virtio_net.c

+2 −3
Original line number Diff line number Diff line
@@ -626,7 +626,7 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) 
	/* This can happen with OOM and indirect buffers. */

	if (unlikely(capacity < 0)) {

		if (likely(capacity == -ENOMEM)) {

			if (net_ratelimit()) {

			if (net_ratelimit())

				dev_warn(&dev->dev,

					 "TX queue failure: out of memory\n");

		} else {
@@ -636,7 +636,6 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) 
					 "Unexpected TX queue failure: %d\n",

					 capacity);

		}

		}

		dev->stats.tx_dropped++;

		kfree_skb(skb);

		return NETDEV_TX_OK;