Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d8dd38a authored by OGAWA Hirofumi's avatar OGAWA Hirofumi Committed by Linus Torvalds
Browse files

vfs: mnt_want_write_file(): fix special file handling 



I suspect that mnt_want_write_file() may have wrong assumption.  I think
mnt_want_write_file() is assuming it increments ->mnt_writers if
(file->f_mode & FMODE_WRITE).  But, if it's special_file(), it is false?

Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Acked-by: default avatarDave Hansen <dave@linux.vnet.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69130c7c

fs/namespace.c

+2 −1
Original line number Diff line number Diff line
@@ -316,7 +316,8 @@ EXPORT_SYMBOL_GPL(mnt_clone_write); 
 */

int mnt_want_write_file(struct file *file)

{

	if (!(file->f_mode & FMODE_WRITE))

	struct inode *inode = file->f_dentry->d_inode;

	if (!(file->f_mode & FMODE_WRITE) || special_file(inode->i_mode))

		return mnt_want_write(file->f_path.mnt);

	else

		return mnt_clone_write(file->f_path.mnt);