Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2bf4fd31 authored by Heinz Graalfs's avatar Heinz Graalfs Committed by Rusty Russell
Browse files

virtio_scsi: verify if queue is broken after virtqueue_get_buf() 



If virtqueue_get_buf() returned with a NULL pointer avoid a possibly
endless loop by checking for a broken virtqueue.

Signed-off-by: default avatarHeinz Graalfs <graalfs@linux.vnet.ibm.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent cdd77e87

drivers/scsi/virtio_scsi.c

+3 −0
Original line number Diff line number Diff line
@@ -224,6 +224,9 @@ static void virtscsi_vq_done(struct virtio_scsi *vscsi, 
		virtqueue_disable_cb(vq);

		while ((buf = virtqueue_get_buf(vq, &len)) != NULL)

			fn(vscsi, buf);



		if (unlikely(virtqueue_is_broken(vq)))

			break;

	} while (!virtqueue_enable_cb(vq));

	spin_unlock_irqrestore(&virtscsi_vq->vq_lock, flags);

}