Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b7edcad authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Airlie
Browse files

drm/virtio: checking for NULL instead of IS_ERR 



virtio_gpu_alloc_object() returns an error pointer, it never returns
NULL.

Fixes: dc5698e8 ('Add virtio gpu driver.')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent dc9be8e2

drivers/gpu/drm/virtio/virtgpu_fb.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -299,8 +299,8 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper, 




	size = mode_cmd.pitches[0] * mode_cmd.height;

	size = mode_cmd.pitches[0] * mode_cmd.height;

	obj = virtio_gpu_alloc_object(dev, size, false, true);

	obj = virtio_gpu_alloc_object(dev, size, false, true);

	if (!obj)

	if (IS_ERR(obj))

		return -ENOMEM;

		return PTR_ERR(obj);





	virtio_gpu_resource_id_get(vgdev, &resid);

	virtio_gpu_resource_id_get(vgdev, &resid);

	virtio_gpu_cmd_create_resource(vgdev, resid, format,

	virtio_gpu_cmd_create_resource(vgdev, resid, format,