Commit 266feefe authored Aug 26, 2008 by Zhao Yakui Committed by Andi Kleen Sep 04, 2008

ACPI: Avoid bogus timeout about SMbus check

In the function of wait_transaction_complete when the timeout happens,
OS will try to check the status of SMbus again. If the status is what OS
expected, it will be regarded as the bogus timeout. Otherwise it will be
treated as ETIME.

http://bugzilla.kernel.org/show_bug.cgi?id=10483



Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
tested-by    : Oldřich Jedlička < <oldium.pro@seznam.cz>
Signed-off-by: Andi Kleen <ak@linux.intel.com>

parent b635acec

drivers/acpi/sbshc.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -107,6 +107,13 @@ static int wait_transaction_complete(struct acpi_smb_hc *hc, int timeout)
		if (wait_event_timeout(hc->wait, smb_check_done(hc),
		msecs_to_jiffies(timeout)))
		return 0;
		/*
		* After the timeout happens, OS will try to check the status of SMbus.
		* If the status is what OS expected, it will be regarded as the bogus
		* timeout.
		*/
		if (smb_check_done(hc))
		return 0;
		else
		return -ETIME;
		}