Commit 265ef3ee authored Apr 05, 2015 by Julia Lawall Committed by Sebastian Reichel Apr 05, 2015

HSI: cmt_speech: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

parent f9c0d76e

drivers/hsi/clients/cmt_speech.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1028,6 +1028,7 @@ static int cs_hsi_start(struct cs_hsi_iface *hi, struct hsi_client cl,
	}		}
	hsi_if->master = ssip_slave_get_master(cl);		hsi_if->master = ssip_slave_get_master(cl);
	if (IS_ERR(hsi_if->master)) {		if (IS_ERR(hsi_if->master)) {
			err = PTR_ERR(hsi_if->master);
	dev_err(&cl->device, "Could not get HSI master client\n");		dev_err(&cl->device, "Could not get HSI master client\n");
	goto leave4;		goto leave4;
	}		}