Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 25e14c1f authored by Xi Wang's avatar Xi Wang Committed by Felipe Balbi
Browse files

usb: gadget: amd5536udc: avoid NULL pointer dereference in udc_pci_probe() 



dev->pdev is NULL before `dev->pdev = pdev'; use pdev instead.

Signed-off-by: default avatarXi Wang <xi.wang@gmail.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent deeeb9ee

drivers/usb/gadget/amd5536udc.c

+2 −2
Original line number Diff line number Diff line
@@ -3231,7 +3231,7 @@ static int udc_pci_probe( 
	}



	if (!pdev->irq) {

		dev_err(&dev->pdev->dev, "irq not set\n");

		dev_err(&pdev->dev, "irq not set\n");

		kfree(dev);

		dev = NULL;

		retval = -ENODEV;
@@ -3250,7 +3250,7 @@ static int udc_pci_probe( 
	dev->txfifo = (u32 __iomem *)(dev->virt_addr + UDC_TXFIFO_ADDR);



	if (request_irq(pdev->irq, udc_irq, IRQF_SHARED, name, dev) != 0) {

		dev_dbg(&dev->pdev->dev, "request_irq(%d) fail\n", pdev->irq);

		dev_dbg(&pdev->dev, "request_irq(%d) fail\n", pdev->irq);

		kfree(dev);

		dev = NULL;

		retval = -EBUSY;