Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d966d03 authored Feb 09, 2015 by Markus Elfring Committed by David S. Miller Feb 09, 2015

net: Mellanox: Delete unnecessary checks before the function call "vunmap"



The vunmap() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Eli Cohen <eli@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c4c65530

drivers/net/ethernet/mellanox/mlx4/alloc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -662,7 +662,7 @@ void mlx4_buf_free(struct mlx4_dev dev, int size, struct mlx4_buf buf)
		buf->direct.buf,
		buf->direct.map);
		else {
		if (BITS_PER_LONG == 64 && buf->direct.buf)
		if (BITS_PER_LONG == 64)
		vunmap(buf->direct.buf);

		for (i = 0; i < buf->nbufs; ++i)

drivers/net/ethernet/mellanox/mlx5/core/alloc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -121,7 +121,7 @@ void mlx5_buf_free(struct mlx5_core_dev dev, struct mlx5_buf buf)
		dma_free_coherent(&dev->pdev->dev, buf->size, buf->direct.buf,
		buf->direct.map);
		else {
		if (BITS_PER_LONG == 64 && buf->direct.buf)
		if (BITS_PER_LONG == 64)
		vunmap(buf->direct.buf);

		for (i = 0; i < buf->nbufs; i++)