Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b644b6e authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

Revert "sunrpc: move the close processing after do recvfrom method" 



This reverts commit b0401d72, which
moved svc_delete_xprt() outside of XPT_BUSY, and allowed it to be called
after svc_xpt_recived(), removing its last reference and destroying it
after it had already been queued for future processing.

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent f5822754

net/sunrpc/svc_xprt.c

+5 −7
Original line number Diff line number Diff line
@@ -706,7 +706,10 @@ int svc_recv(struct svc_rqst *rqstp, long timeout) 
	spin_unlock_bh(&pool->sp_lock);



	len = 0;

	if (test_bit(XPT_LISTENER, &xprt->xpt_flags)) {

	if (test_bit(XPT_CLOSE, &xprt->xpt_flags)) {

		dprintk("svc_recv: found XPT_CLOSE\n");

		svc_delete_xprt(xprt);

	} else if (test_bit(XPT_LISTENER, &xprt->xpt_flags)) {

		struct svc_xprt *newxpt;

		newxpt = xprt->xpt_ops->xpo_accept(xprt);

		if (newxpt) {
@@ -732,7 +735,7 @@ int svc_recv(struct svc_rqst *rqstp, long timeout) 
			svc_xprt_received(newxpt);

		}

		svc_xprt_received(xprt);

	} else if (!test_bit(XPT_CLOSE, &xprt->xpt_flags)) {

	} else {

		dprintk("svc: server %p, pool %u, transport %p, inuse=%d\n",

			rqstp, pool->sp_id, xprt,

			atomic_read(&xprt->xpt_ref.refcount));
@@ -745,11 +748,6 @@ int svc_recv(struct svc_rqst *rqstp, long timeout) 
		dprintk("svc: got len=%d\n", len);

	}



	if (test_bit(XPT_CLOSE, &xprt->xpt_flags)) {

		dprintk("svc_recv: found XPT_CLOSE\n");

		svc_delete_xprt(xprt);

	}



	/* No data, incomplete (TCP) read, or accept() */

	if (len == 0 || len == -EAGAIN) {

		rqstp->rq_res.len = 0;