Commit 189c9b8d authored Nov 25, 2013 by Paul Walmsley Committed by Rafael J. Wysocki Dec 06, 2013

cpufreq: SPEAr: clk_round_rate() can return a zero upon error



Treat both negative and zero return values from clk_round_rate()
as errors.  This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather
than a signed type, since some clock sources can generate rates
higher than (2^31)-1 Hz.

Eventually, when calling clk_round_rate(), only a return value of
zero will be considered a error.  All other values will be
considered valid rates.  The comparison against values less than
0 is kept to preserve the correct behavior in the meantime.

Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 2209b0c9

drivers/cpufreq/spear-cpufreq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -138,7 +138,7 @@ static int spear_cpufreq_target(struct cpufreq_policy *policy,
		}

		newfreq = clk_round_rate(srcclk, newfreq * mult);
		if (newfreq < 0) {
		if (newfreq <= 0) {
		pr_err("clk_round_rate failed for cpu src clock\n");
		return newfreq;
		}