Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fb9f2aa authored by Rabin Vincent's avatar Rabin Vincent Committed by Arnaldo Carvalho de Melo
Browse files

perf annotate: Fix memory leaks in LOCK handling 



The lock prefix handling fails to free the strdup()'d name as well as
the fields allocated by the instruction parsing.

Signed-off-by: default avatarRabin Vincent <rabin@rab.in>
Cc: Paul Mackerras <paulus@samba.org>
Link: http://lkml.kernel.org/r/1421607621-15005-2-git-send-email-rabin@rab.in


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent be81908c

tools/perf/util/annotate.c

+9 −0
Original line number Diff line number Diff line
@@ -177,6 +177,8 @@ static int lock__parse(struct ins_operands *ops) 
		goto out_free_ops;



	ops->locked.ins = ins__find(name);

	free(name);



	if (ops->locked.ins == NULL)

		goto out_free_ops;
@@ -209,6 +211,13 @@ static int lock__scnprintf(struct ins *ins, char *bf, size_t size, 


static void lock__delete(struct ins_operands *ops)

{

	struct ins *ins = ops->locked.ins;



	if (ins && ins->ops->free)

		ins->ops->free(ops->locked.ops);

	else

		ins__delete(ops->locked.ops);



	zfree(&ops->locked.ops);

	zfree(&ops->target.raw);

	zfree(&ops->target.name);