Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f8ee7fc authored by Stefan Raspl's avatar Stefan Raspl Committed by David S. Miller
Browse files

qeth: Fix default queue setting in priority queueing 



The default queue for queueing modes prio_queueing_prec and
prio_queueing_tos is supposed to be QETH_DEFAULT_QUEUE. However, neither
mode will reset the default default_out_queue value when enabled, leaving
a previously set value activate as the default.
E.g. enabling one of the fixed queueing modes, e.g. no_prio_queueing:0,
and successively switching to any of the prio_queueing_* modes will
leave default_out_queue at the previous (wrong) value 0.

Signed-off-by: default avatarStefan Raspl <raspl@linux.vnet.ibm.com>
Signed-off-by: default avatarFrank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d39a7435

drivers/s390/net/qeth_core_sys.c

+5 −3
Original line number Diff line number Diff line
@@ -250,11 +250,13 @@ static ssize_t qeth_dev_prioqing_store(struct device *dev, 
	}



	tmp = strsep((char **) &buf, "\n");

	if (!strcmp(tmp, "prio_queueing_prec"))

	if (!strcmp(tmp, "prio_queueing_prec")) {

		card->qdio.do_prio_queueing = QETH_PRIO_Q_ING_PREC;

	else if (!strcmp(tmp, "prio_queueing_tos"))

		card->qdio.default_out_queue = QETH_DEFAULT_QUEUE;

	} else if (!strcmp(tmp, "prio_queueing_tos")) {

		card->qdio.do_prio_queueing = QETH_PRIO_Q_ING_TOS;

	else if (!strcmp(tmp, "no_prio_queueing:0")) {

		card->qdio.default_out_queue = QETH_DEFAULT_QUEUE;

	} else if (!strcmp(tmp, "no_prio_queueing:0")) {

		card->qdio.do_prio_queueing = QETH_NO_PRIO_QUEUEING;

		card->qdio.default_out_queue = 0;

	} else if (!strcmp(tmp, "no_prio_queueing:1")) {