Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0e90ad9b authored by Shahed Shaikh's avatar Shahed Shaikh Committed by David S. Miller
Browse files

qlcnic: Don't use kzalloc unncecessarily for allocating large chunk of memory 



Driver allocates a large chunk of temporary buffer using kzalloc
to copy FW image. As there is no real need of this memory to be
physically contiguous, use vzalloc instead.

Signed-off-by: default avatarShahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent da286a6f

drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c

+2 −2
Original line number Diff line number Diff line
@@ -1384,7 +1384,7 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter) 
	size_t size;

	u64 addr;



	temp = kzalloc(fw->size, GFP_KERNEL);

	temp = vzalloc(fw->size);

	if (!temp) {

		release_firmware(fw);

		fw_info->fw = NULL;
@@ -1430,7 +1430,7 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter) 
exit:

	release_firmware(fw);

	fw_info->fw = NULL;

	kfree(temp);

	vfree(temp);



	return ret;

}