Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0db4e162 authored by Kamil Krawczyk's avatar Kamil Krawczyk Committed by Jeff Kirsher
Browse files

i40e: poll firmware slower 



The code was polling the firmware tail register for completion every
10 microseconds, which is way faster than the firmware can respond.
This changes the poll interval to 1ms, which reduces polling CPU
utilization, and the number of times we loop.

The maximum delay is still 100ms.

Change-ID: I4bbfa6b66d802890baf8b4154061e55942b90958
Signed-off-by: default avatarKamil Krawczyk <kamil.krawczyk@intel.com>
Acked-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 2e1af7d7

drivers/net/ethernet/intel/i40e/i40e_adminq.c

+2 −4
Original line number Diff line number Diff line
@@ -853,7 +853,6 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw, 
	 */

	if (!details->async && !details->postpone) {

		u32 total_delay = 0;

		u32 delay_len = 10;



		do {

			/* AQ designers suggest use of head for better
@@ -861,9 +860,8 @@ i40e_status i40e_asq_send_command(struct i40e_hw *hw, 
			 */

			if (i40e_asq_done(hw))

				break;

			/* ugh! delay while spin_lock */

			udelay(delay_len);

			total_delay += delay_len;

			usleep_range(1000, 2000);

			total_delay++;

		} while (total_delay < hw->aq.asq_cmd_timeout);

	}

drivers/net/ethernet/intel/i40e/i40e_adminq.h

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static inline int i40e_aq_rc_to_posix(u16 aq_rc) 


/* general information */

#define I40E_AQ_LARGE_BUF	512

#define I40E_ASQ_CMD_TIMEOUT	100000  /* usecs */

#define I40E_ASQ_CMD_TIMEOUT	100  /* msecs */



void i40e_fill_default_direct_cmd_desc(struct i40e_aq_desc *desc,

				       u16 opcode);

drivers/net/ethernet/intel/i40evf/i40e_adminq.c

+2 −4
Original line number Diff line number Diff line
@@ -801,7 +801,6 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw, 
	 */

	if (!details->async && !details->postpone) {

		u32 total_delay = 0;

		u32 delay_len = 10;



		do {

			/* AQ designers suggest use of head for better
@@ -809,9 +808,8 @@ i40e_status i40evf_asq_send_command(struct i40e_hw *hw, 
			 */

			if (i40evf_asq_done(hw))

				break;

			/* ugh! delay while spin_lock */

			udelay(delay_len);

			total_delay += delay_len;

			usleep_range(1000, 2000);

			total_delay++;

		} while (total_delay < hw->aq.asq_cmd_timeout);

	}

drivers/net/ethernet/intel/i40evf/i40e_adminq.h

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static inline int i40e_aq_rc_to_posix(u16 aq_rc) 


/* general information */

#define I40E_AQ_LARGE_BUF	512

#define I40E_ASQ_CMD_TIMEOUT	100000  /* usecs */

#define I40E_ASQ_CMD_TIMEOUT	100  /* msecs */



void i40evf_fill_default_direct_cmd_desc(struct i40e_aq_desc *desc,

				       u16 opcode);