Commit 0ce7d00d authored Jan 27, 2013 by Axel Lin Committed by Mark Brown Jan 30, 2013

regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match

The dev parameter is the device requesting the data.
In this case it should be &pdev->dev rather than pdev->dev.parent.

The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(),
which means this fixes a memory leak because the memory is allocated every time
probe() is called, thus it should be freed when this driver is unloaded.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 6116ad94

drivers/regulator/tps6507x-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data(
		count = ARRAY_SIZE(tps6507x_matches);
		matches = tps6507x_matches;

		ret = of_regulator_match(pdev->dev.parent, regulators, matches, count);
		ret = of_regulator_match(&pdev->dev, regulators, matches, count);
		if (ret < 0) {
		dev_err(&pdev->dev, "Error parsing regulator init data: %d\n",
		ret);