Commit 0576eddf authored Mar 28, 2014 by Paul Durrant Committed by David S. Miller Mar 29, 2014

xen-netback: remove pointless clause from if statement

This patch removes a test in start_new_rx_buffer() that checks whether
a copy operation is less than MAX_BUFFER_OFFSET in length, since
MAX_BUFFER_OFFSET is defined to be PAGE_SIZE and the only caller of
start_new_rx_buffer() already limits copy operations to PAGE_SIZE or less.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>
Reported-By: Sander Eikelenboom <linux@eikelenboom.it>
Tested-By: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 49d8137a

drivers/net/xen-netback/netback.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -192,8 +192,8 @@ static bool start_new_rx_buffer(int offset, unsigned long size, int head)
	* into multiple copies tend to give large frags their		* into multiple copies tend to give large frags their
	* own buffers as before.		* own buffers as before.
	*/		*/
	if ((offset + size > MAX_BUFFER_OFFSET) &&		BUG_ON(size > MAX_BUFFER_OFFSET);
	(size <= MAX_BUFFER_OFFSET) && offset && !head)		if ((offset + size > MAX_BUFFER_OFFSET) && offset && !head)
	return true;		return true;

	return false;		return false;