Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 016d3569 authored by Krzysztof Helt's avatar Krzysztof Helt Committed by Linus Torvalds
Browse files

mx3fb: fix regression with uninitalized fb_info->mm_lock mutex 



Remove call to the mx3fb_set_par() and the mx3fb_blank() before the
register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf0 " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent afecb0d0

drivers/video/mx3fb.c

+0 −5
Original line number Diff line number Diff line
@@ -1365,11 +1365,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan) 
	init_completion(&mx3fbi->flip_cmpl);

	disable_irq(ichan->eof_irq);

	dev_dbg(mx3fb->dev, "disabling irq %d\n", ichan->eof_irq);

	ret = mx3fb_set_par(fbi);

	if (ret < 0)

		goto esetpar;



	mx3fb_blank(FB_BLANK_UNBLANK, fbi);



	dev_info(dev, "registered, using mode %s\n", fb_mode);