Commit fc9f8994 authored Jul 09, 2011 by Julia Lawall Committed by Joel Becker Nov 17, 2011

fs/ocfs2/dlm/dlmlock.c: free kmem_cache_zalloc'd data using kmem_cache_free

Memory allocated using kmem_cache_zalloc should be freed using
kmem_cache_free, not kfree.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression x,e,e1,e2;
@@

x = kmem_cache_zalloc(e1,e2)
... when != x = e
?-kfree(x)
+kmem_cache_free(e1,x)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Joel Becker <jlbec@evilplan.org>

parent 99b1bb61

fs/ocfs2/dlm/dlmlock.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -438,7 +438,7 @@ struct dlm_lock * dlm_new_lock(int type, u8 node, u64 cookie,
		/* zero memory only if kernel-allocated */
		lksb = kzalloc(sizeof(*lksb), GFP_NOFS);
		if (!lksb) {
		kfree(lock);
		kmem_cache_free(dlm_lock_cache, lock);
		return NULL;
		}
		kernel_allocated = 1;