Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f78ec6b2 authored by Dan Carpenter's avatar Dan Carpenter Committed by David Woodhouse
Browse files

mtd/m25p80: fix test for end of loop 



"plat_id" is always non-NULL here.  There is a zero element on the end
of the m25p_ids[] array and if we hit the end of the loop then plat_id
points to that.

This would lead to a NULL pointer dereference later on in the function.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarAnton Vorontsov <cbouatmailru@gmail.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent b06cd21e

drivers/mtd/devices/m25p80.c

+1 −1
Original line number Diff line number Diff line
@@ -793,7 +793,7 @@ static int __devinit m25p_probe(struct spi_device *spi) 
			break;

		}



		if (plat_id)

		if (i < ARRAY_SIZE(m25p_ids) - 1)

			id = plat_id;

		else

			dev_warn(&spi->dev, "unrecognized id %s\n", data->type);