Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6302f1b authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

relay: prevent integer overflow in relay_open() 



"subbuf_size" and "n_subbufs" come from the user and they need to be
capped to prevent an integer overflow.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 306df071

kernel/relay.c

+8 −2
Original line number Diff line number Diff line
@@ -164,10 +164,14 @@ depopulate: 
 */

static struct rchan_buf *relay_create_buf(struct rchan *chan)

{

	struct rchan_buf *buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL);

	if (!buf)

	struct rchan_buf *buf;



	if (chan->n_subbufs > UINT_MAX / sizeof(size_t *))

		return NULL;



	buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL);

	if (!buf)

		return NULL;

	buf->padding = kmalloc(chan->n_subbufs * sizeof(size_t *), GFP_KERNEL);

	if (!buf->padding)

		goto free_buf;
@@ -574,6 +578,8 @@ struct rchan *relay_open(const char *base_filename, 


	if (!(subbuf_size && n_subbufs))

		return NULL;

	if (subbuf_size > UINT_MAX / n_subbufs)

		return NULL;



	chan = kzalloc(sizeof(struct rchan), GFP_KERNEL);

	if (!chan)