Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f469ec9c authored by Jan Kara's avatar Jan Kara Committed by Fengguang Wu
Browse files

fs: Remove bogus wait in write_inode_now() 



inode_sync_wait() in write_inode_now() is just bogus. That function waits for
I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return
so the wait is effectivelly a nop unless someone else submits the inode for
writeback again. All the waiting write_inode_now() needs is achieved by using
WB_SYNC_ALL writeback mode.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
parent 9f8050c4

fs/fs-writeback.c

+0 −2
Original line number Diff line number Diff line
@@ -1364,8 +1364,6 @@ int write_inode_now(struct inode *inode, int sync) 
	ret = writeback_single_inode(inode, wb, &wbc);

	spin_unlock(&inode->i_lock);

	spin_unlock(&wb->list_lock);

	if (sync)

		inode_sync_wait(inode);

	return ret;

}

EXPORT_SYMBOL(write_inode_now);