Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f229006e authored Feb 25, 2014 by James Hogan

irq-metag*: stop set_affinity vectoring to offline cpus



Fix irq_set_affinity callbacks in the Meta IRQ chip drivers to AND
cpu_online_mask into the cpumask when picking a CPU to vector the
interrupt to.

As Thomas pointed out, the /proc/irq/$N/smp_affinity interface doesn't
filter out offline CPUs, so without this patch if you offline CPU0 and
set an IRQ affinity to 0x3 it vectors the interrupt onto CPU0 even
though it is offline.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-metag@vger.kernel.org
Cc: stable@vger.kernel.org

parent e6cfc029

drivers/irqchip/irq-metag-ext.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -515,7 +515,7 @@ static int meta_intc_set_affinity(struct irq_data *data,
		* one cpu (the interrupt code doesn't support it), so we just
		* pick the first cpu we find in 'cpumask'.
		*/
		cpu = cpumask_any(cpumask);
		cpu = cpumask_any_and(cpumask, cpu_online_mask);
		thread = cpu_2_hwthread_id[cpu];

		metag_out32(TBI_TRIG_VEC(TBID_SIGNUM_TR2(thread)), vec_addr);

drivers/irqchip/irq-metag.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -201,7 +201,7 @@ static int metag_internal_irq_set_affinity(struct irq_data *data,
		* one cpu (the interrupt code doesn't support it), so we just
		* pick the first cpu we find in 'cpumask'.
		*/
		cpu = cpumask_any(cpumask);
		cpu = cpumask_any_and(cpumask, cpu_online_mask);
		thread = cpu_2_hwthread_id[cpu];

		metag_out32(TBI_TRIG_VEC(TBID_SIGNUM_TR1(thread)),