Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef80d1e1 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by James Bottomley
Browse files

[SCSI] sd: Do not call do_div() with a 64-bit divisor 



do_div() is meant for divisions of 64-bit number by 32-bit numbers.
Passing 64-bit divisor types caused issues in the past on 32-bit platforms,
cfr. commit ea077b1b ("m68k: Truncate base
in do_div()").

As scsi_device.sector_size is unsigned (int), factor should be unsigned
int, too.

Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent b28d108b

drivers/scsi/sd.c

+1 −1
Original line number Diff line number Diff line
@@ -1626,7 +1626,7 @@ static unsigned int sd_completed_bytes(struct scsi_cmnd *scmd) 
		end_lba <<= 1;

	} else {

		/* be careful ... don't want any overflows */

		u64 factor = scmd->device->sector_size / 512;

		unsigned int factor = scmd->device->sector_size / 512;

		do_div(start_lba, factor);

		do_div(end_lba, factor);

	}