Commit e3efe3be authored Mar 31, 2014 by Stephen Warren Committed by Mark Brown Apr 01, 2014

ASoC: alc5632: fix uninit var in alc5632_probe()



alc5632_probe() returns ret, yet it is not initialized or set anywhere.
This ends up causing the function to appear to fail, and audio not to
work on the Toshiba AC100, with my compiler at least.

This function used to set ret in all cases, but recent cleanup removed
that.

Fixes: 5d6be5aa ("ASoC: codec: Simplify ASoC probe code.")
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent c159a850

sound/soc/codecs/alc5632.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1061,7 +1061,6 @@ static int alc5632_resume(struct snd_soc_codec *codec)
		static int alc5632_probe(struct snd_soc_codec *codec)
		{
		struct alc5632_priv *alc5632 = snd_soc_codec_get_drvdata(codec);
		int ret;

		/* power on device */
		alc5632_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
		@@ -1075,7 +1074,7 @@ static int alc5632_probe(struct snd_soc_codec *codec)
		return -EINVAL;
		}

		return ret;
		return 0;
		}

		/* power down chip */