Commit e306dfd0 authored Feb 14, 2014 by Olof Johansson Committed by Catalin Marinas Feb 17, 2014

ARM64: unwind: Fix PC calculation



The frame PC value in the unwind code used to just take the saved LR
value and use that.  That's incorrect as a stack trace, since it shows
the return path stack, not the call path stack.

In particular, it shows faulty information in case the bl is done as
the very last instruction of one label, since the return point will be
in the next label. That can easily be seen with tail calls to panic(),
which is marked __noreturn and thus doesn't have anything useful after it.

Easiest here is to just correct the unwind code and do a -4, to get the
actual call site for the backtrace instead of the return site.

Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: stable@vger.kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

parent 6d0abeca

arch/arm64/kernel/stacktrace.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -48,7 +48,11 @@ int unwind_frame(struct stackframe *frame)

		frame->sp = fp + 0x10;
		frame->fp = (unsigned long )(fp);
		frame->pc = (unsigned long )(fp + 8);
		/*
		* -4 here because we care about the PC at time of bl,
		* not where the return will go.
		*/
		frame->pc = (unsigned long )(fp + 8) - 4;

		return 0;
		}